> On May 3, 2017, 2:54 p.m., Robert Levas wrote: > > Ship It! > > Anita Jebaraj wrote: > Thank you Robert, please help in pushing the changes
Committed to trunk ``` commit 7cc5e9e220b82052256a352f0e65323f2b1bc962 Author: Anita Jebaraj <[email protected]> Date: Thu May 4 15:43:33 2017 -0400 ``` Committed to branch-2.5 ``` commit f8f8abbbbad230c574d8bcdb971ea59900a8dc7a Author: Anita Jebaraj <[email protected]> Date: Thu May 4 15:45:37 2017 -0400 ``` - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58968/#review173790 ----------------------------------------------------------- On May 3, 2017, 2:24 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58968/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 2:24 p.m.) > > > Review request for Ambari, Attila Doroszlai, Di Li, Robert Levas, and Tim > Thorpe. > > > Bugs: AMBARI-20909 > https://issues.apache.org/jira/browse/AMBARI-20909 > > > Repository: ambari > > > Description > ------- > > Create a local user "test" in Ambari > > Create a system user "test" with different password > > Trying to authenticate via pam in Ambari UI as user "test" throws Server > Error in Ambari UI, without any error in Ambari-server logs > > Also the UI gets stalled and not even able to login as admin user unless the > browser cache is removed or Ambari UI is opened in a new browser page > > Ambari doesn't allow creating users with same user name but different > types(Local/pam), We reach the pam authentication only when the local user > authentication failed due to non-existing userid or incorrect password, So if > local user exists do not attempt to authenticate via PAM, This lets Ambari to > avoid importing duplicate userid into the database > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java > b3fb861 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java > b7272c5 > > > Diff: https://reviews.apache.org/r/58968/diff/2/ > > > Testing > ------- > > Updated the related test cases > > > File Attachments > ---------------- > > Ambari-20909-Branch2.5.patch > > https://reviews.apache.org/media/uploaded/files/2017/05/03/3899b0bb-110a-449b-a401-4ba0576957fc__AMBARI-20909-Branch2.5.patch > > > Thanks, > > Anita Jebaraj > >
