> On May 4, 2017, 7:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 221 (patched)
> > <https://reviews.apache.org/r/58995/diff/1/?file=1708375#file1708375line221>
> >
> > We should use stack_root and avoid harcoding HDP or HDF.
>
> Vishal Suvagia wrote:
> Hi Alejandro,
> As Nifi will be an HDP add-on service, and bits for Nifi will
> be installed under path /usr/hdf/{stack-version} from HDF repos even in an
> HDP stack cluster. So to differentiate between HDF(for Nifi) and HDP, we will
> need to keep the stack-checks.
Can you pass cred_lib_path_override and cred_setup_prefix_override parameters
to this function and in NIFI pass these parameters explicit;y. That way we can
get rid of both the hardcodings.
if service_name == 'nifi':
AND
if stack_name == 'HDP':
Let NIFI explicitly handle this in their service definition and pass in the
override parameters, instead of the utility function in resource_management
library having these hardcodings.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
-----------------------------------------------------------
On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 3:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya,
> Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support to enable Ranger Nifi plugin.
>
>
> Diffs
> -----
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> c510dac
>
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml
> 661089a
>
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json
> 87fccbe
>
>
> Diff: https://reviews.apache.org/r/58995/diff/1/
>
>
> Testing
> -------
>
> Verified fresh installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
