----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58995/#review174056 -----------------------------------------------------------
Fix it, then Ship it! Fix it and ship it ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py Line 52 (original), 52 (patched) <https://reviews.apache.org/r/58995/#comment247162> Nitpick, add some spaces after the comma ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py Line 217 (original), 216 (patched) <https://reviews.apache.org/r/58995/#comment247161> Change this to if cred_lib_path_override is not None: cred_lib_path = cred_lib_path_override else: cred_lib_path = format('{stack_root}/{stack_version}/ranger-{service_name}-plugin/install/lib/*') - Alejandro Fernandez On May 5, 2017, 1:44 p.m., Vishal Suvagia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58995/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 1:44 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, > Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy. > > > Bugs: AMBARI-20932 > https://issues.apache.org/jira/browse/AMBARI-20932 > > > Repository: ambari > > > Description > ------- > > Add support to enable Ranger Nifi plugin. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > c510dac > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml > 661089a > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json > 87fccbe > > > Diff: https://reviews.apache.org/r/58995/diff/2/ > > > Testing > ------- > > Verified fresh installation on Cent-OS 6. > > > Thanks, > > Vishal Suvagia > >
