> On 五月 23, 2017, 11:41 a.m., Alexandr Antonenko wrote: > > Ship It! > > yao lei wrote: > Thanks for your review > > yao lei wrote: > Hi Alexandr Antonenko, > Would you please commit this patch if you are free? > Thanks. > > Alexandr Antonenko wrote: > in trunk this changes are already in their place, after commit > Ambari-18281 Expose Disabling of Alert Targets in Web Client (Vivek Ratnavel > Subramanian via zhewang) > > as for 2.5 branch, 2.5.2 RC is out, so no commits to that branch (only > critical blockers) > > yao lei wrote: > I see. > Thanks Alexandr. > > Alexandr Antonenko wrote: > once 2.5.2 will be out, and we will start working on 2.5.3 (so 2.5 branch > will be opened for commits). Let's push it there. If your goal is to fix this > for 2.5.3
Good. Please commit to 2.5.3 - yao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59485/#review175785 ----------------------------------------------------------- On 五月 23, 2017, 8:10 a.m., yao lei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59485/ > ----------------------------------------------------------- > > (Updated 五月 23, 2017, 8:10 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, > and Yusaku Sako. > > > Bugs: AMBARI-21097 > https://issues.apache.org/jira/browse/AMBARI-21097 > > > Repository: ambari > > > Description > ------- > > STR: > 1.Open Alerts / Actions / Manage Alert Notifications > 2.Create an alert notification named test > 3.Select the created notification and click gear icon, you will find > Edit/Duplicate items are always grey but you can click and open a popup. > > > Diffs > ----- > > ambari-web/app/mappers/alert_notification_mapper.js 037c418 > ambari-web/app/models/alerts/alert_notification.js c2d7570 > > > Diff: https://reviews.apache.org/r/59485/diff/1/ > > > Testing > ------- > > 1.cd ambari-web & mvn test > 30383 passing (34s) > 157 pending > > 2.Tested in a cluster > > > Thanks, > > yao lei > >
