> On 六月 5, 2017, 8:54 p.m., Richard Zang wrote: > > Ship It!
Thanks for your review - yao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59485/#review176949 ----------------------------------------------------------- On 六月 5, 2017, 10:28 a.m., yao lei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59485/ > ----------------------------------------------------------- > > (Updated 六月 5, 2017, 10:28 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-21097 > https://issues.apache.org/jira/browse/AMBARI-21097 > > > Repository: ambari > > > Description > ------- > > Two Problems > > Steps to reproduce problem one (see notifiction.png): > 1.Open Alerts / Actions / Manage Alert Notifications > 2.Create an alert notification named test > 3.Select the created notification and click gear icon, you will find > Edit/Duplicate items are always grey but you can click and open a popup. > > Steps to reproduce problem two(see notification-2.png): > 1.Open Alerts / Actions / Manage Alert Notifications and delete all > notifications if exit > 2.Firstly click the gear icon and then click Edit(Duplicate) item, some > errors will ouput in browser console. > > > Diffs > ----- > > ambari-web/app/mappers/alert_notification_mapper.js 037c418 > ambari-web/app/models/alerts/alert_notification.js c2d7570 > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs > da8faa8 > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js aa05f86 > > > Diff: https://reviews.apache.org/r/59485/diff/2/ > > > Testing > ------- > > 1.cd ambari-web & mvn test > 30383 passing (34s) > 157 pending > > 2.Tested in a cluster > > > File Attachments > ---------------- > > notification-2.png > > https://reviews.apache.org/media/uploaded/files/2017/06/05/9c1d5973-8ced-4483-bdd3-e3d461c5dee2__notification-2.png > notification.png > > https://reviews.apache.org/media/uploaded/files/2017/06/05/5ddcf172-e529-40ec-abe0-6c0cee83208f__notification.png > > > Thanks, > > yao lei > >
