> On May 26, 2017, 2:57 p.m., Robert Levas wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 1234 (patched) > > <https://reviews.apache.org/r/59503/diff/3/?file=1731985#file1731985line1234> > > > > Why not combine the prompt and the creating of the account here?
It can be done, but currently all the prompts are given during setup and then the creation is done (creating tables, creating schema etc.), so I just wanted to follow similar approach, rather than prompting create admin user later - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review176197 ----------------------------------------------------------- On May 24, 2017, 8:40 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 8:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > ------- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > ----- > > ambari-server/docs/configuration/index.md ff9ce54 > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 9cdde8f > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/3/ > > > Testing > ------- > > Added 1 test case > > > Ran mvn test > > > File Attachments > ---------------- > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
