> On May 26, 2017, 2:57 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Line 350 (original), 350-356 (patched) > > <https://reviews.apache.org/r/59503/diff/3/?file=1731981#file1731981line350> > > > > This is no longer needed if the trigger to create the admin user is > > based on the existing of an administrator user or not. > > Anita Jebaraj wrote: > Hi Robert, the check if an administrator user exists or not is done in > the createUserHelper class, but this doesn't stop the prompt from being > displayed during ambari-server setup, If I dont have this flag, then the user > will be prompted to enter custom admin user, and later it fails. I thought > there is no point in displaying the prompt during setup again if the user is > already created > > I am not sure if having a java executable command to check if admin user > exists is a good idea. Please let me know how you want this to be handled. > > Robert Levas wrote: > Somehow the setup program knows it has been executed once. Can this > information be used instead? Or maybe a combination of that data and a query > on the database to check for an administrator user? This flag feels to be > unnecessary and will unnecessarily clutter up the ambari.properties file.
same as above, using the property server.jdbc.database_name - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review176197 ----------------------------------------------------------- On June 1, 2017, 6:08 a.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 6:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > ------- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java > 9cdde8f > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/5/ > > > Testing > ------- > > Added 1 test case > > > Ran mvn test > > > File Attachments > ---------------- > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
