----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60365/#review178714 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java Lines 1634 (patched) <https://reviews.apache.org/r/60365/#comment252864> This code change looks good. I wonder if we can or should throw an error if the same version tag is sent. Perhaps its not an error scenario and in that case we can just log a WARN that config update API got a call with same tag. - Sumit Mohanty On June 22, 2017, 11:34 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60365/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 11:34 a.m.) > > > Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid > Wagle. > > > Bugs: AMBARI-21317 > https://issues.apache.org/jira/browse/AMBARI-21317 > > > Repository: ambari > > > Description > ------- > > Currently, a config update expects a tag value from the client calling the > API. It should be optional and if not provided then BE should generate a > unique tag and auto add. > > {code} > [{"Clusters":{ > "desired_config":[{ > "type":"zoo.cfg", > "tag":"version1495042583018", > "properties":{... > ... > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > ed707e7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > c0e3ef1 > > > Diff: https://reviews.apache.org/r/60365/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
