Re: Review Request 60365: Config update API should not need to have a unique tag, BE can auto add the tag when it is missing

[Vitalyi Brodetskyi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60365/
-----------------------------------------------------------

(Updated Червень 26, 2017, 1:06 після полудня)


Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-21317
    https://issues.apache.org/jira/browse/AMBARI-21317


Repository: ambari


Description
-------

Currently, a config update expects a tag value from the client calling the API. 
It should be optional and if not provided then BE should generate a unique tag 
and auto add.

{code}
[{"Clusters":{
  "desired_config":[{
    "type":"zoo.cfg",
    "tag":"version1495042583018",
    "properties":{...
...
{code}


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 bb1c95e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ed707e7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigGroupResponse.java
 58c680d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 c2b998c 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
65b7863 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 c0e3ef1 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
 12cbadf 


Diff: https://reviews.apache.org/r/60365/diff/2/

Changes: https://reviews.apache.org/r/60365/diff/1-2/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi