----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60595/#review179502 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryAction.java Lines 40 (patched) <https://reviews.apache.org/r/60595/#comment254246> That would be an awesome new feature! ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryAction.java Lines 60-61 (patched) <https://reviews.apache.org/r/60595/#comment254247> Clusters.getCluster(String) throws a ClusterNotFoundException - no need for the NULL check. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryAction.java Lines 68-69 (patched) <https://reviews.apache.org/r/60595/#comment254248> Not sure how this could be null - probably don't need this check. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryAction.java Lines 72 (patched) <https://reviews.apache.org/r/60595/#comment254249> Use System.lineSeparator here instead of \n - Jonathan Hurley On July 3, 2017, 6:32 a.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60595/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 6:32 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit > Mohanty. > > > Bugs: AMBARI-21390 > https://issues.apache.org/jira/browse/AMBARI-21390 > > > Repository: ambari > > > Description > ------- > > Old and new stack root paths are hard-coded for now. I will try to make it > configurable later. > The patch also copies BigInsights 4.2 upgrade pack to 4.2.5 to be able to > upgrade from the latter version. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryAction.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > e8a1e33545c17faaf5856b77b77c4621249bb4ac > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryActionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60595/diff/1/ > > > Testing > ------- > > Manual test on local cluster. > New unit test. > > > Thanks, > > Attila Doroszlai > >
