> On July 5, 2017, 5:09 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryAction.java > > Lines 74 (patched) > > <https://reviews.apache.org/r/60595/diff/2/?file=1768456#file1768456line74> > > > > We need to change other things just besides the stack root. > > There are other references to > > > > iop/apps > > iop-select > > > > Because this is specific to IOP to HDP, I suggest putting IOPtoHDP in > > the class name.
Also things like $iop.version - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60595/#review179655 ----------------------------------------------------------- On July 3, 2017, 2:19 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60595/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 2:19 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit > Mohanty. > > > Bugs: AMBARI-21390 > https://issues.apache.org/jira/browse/AMBARI-21390 > > > Repository: ambari > > > Description > ------- > > Old and new stack root paths are hard-coded for now. I will try to make it > configurable later. > The patch also copies BigInsights 4.2 upgrade pack to 4.2.5 to be able to > upgrade from the latter version. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryAction.java > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > e8a1e33545c17faaf5856b77b77c4621249bb4ac > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ChangeStackRootDirectoryActionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60595/diff/2/ > > > Testing > ------- > > Manual test on local cluster. > New unit test. > > > Thanks, > > Attila Doroszlai > >
