----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60249/#review179569 -----------------------------------------------------------
```<restartRequiredAfterRackChange>true</restartRequiredAfterRackChange>``` needs to be added to the ```metainfo.xml``` for Kafka otherwise Ambari will not flag Kafka to be restarted in case the rack info for a host changed. Without this the user may forget to restart Kafka thus the rack info change will not make to Kafka. This change has to be added to the version of Kafka that support rack awareness as it has no sense for older verions of Kafka that doesn't support rack awareness to be marked by Ambari to be restarted whenever the rack information for hosts changes. - Sebastian Toader On June 28, 2017, 1:10 a.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60249/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 1:10 a.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Repository: ambari > > > Description > ------- > > Ambari rack awareness for Kafka. > https://issues.apache.org/jira/browse/AMBARI-21234 > > As an operations person it would be nice to manage Kafka rack awareness via > Ambari. Ambari allows node rack information to be configured and this > information can then be pulled in the Kafka stack and populated in the > server.properties file for Kafka. > Design: > This stack change uses the /clusterHostInfo/all_hosts and > /clusterHostInfo/all_racks paths and materializes them to a variable. Then it > uses linear search to find this node in the list of all hosts and it's > corresponding rack id. This information is then stored in a variable called > rack and which is materialized during the configure method of the broker > scripts. > This stack change relies on the node rack information stored in Ambari > therefore will enable both Ambari UI and Blueprints to be used for setting up > Kafka broker rack information. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > 1327090aa7 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > c36a10ff28 > > > Diff: https://reviews.apache.org/r/60249/diff/4/ > > > Testing > ------- > > Manually deployed Kafka cluster and verified the broker.rack property is > correctly populated. > > > Thanks, > > Ambud Sharma > >
