----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60249/#review180292 -----------------------------------------------------------
A few observations regarding the *trunk* patch: - HDP/2.6/services/KAFKA/metainfo.xml ```<extends>common-services/KAFKA/0.10.0</extends>```. This is not needed as HDP/2.6 already extends HDP/2.5 (see HDP/2.6/metainfo.xml) thus HDP/2.6/services/KAFKA/metainfo.xml inherits from HDP/2.5/services/KAFKA/metainfo.xml which in turn ```<extends>common-services/KAFKA/0.10.0</extends>``` - HDP/3.0/services/KAFKA doesn't seem to have the rack awarness implementation. Note HDP 3.0 doesn't derive from HDP2.6 thus the rack awarness code has to be added to ommon-services/KAFKA/0.10.0.3.0 as well. ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/metainfo.xml Lines 24 (patched) <https://reviews.apache.org/r/60249/#comment255374> This is not needed as HDP/2.6 already inherits from HDP/2.5 and HDP/2.5/services/KAFKA/metainfo.xml has this - Sebastian Toader On July 11, 2017, 8:19 a.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60249/ > ----------------------------------------------------------- > > (Updated July 11, 2017, 8:19 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Sriharsha Chintalapani. > > > Repository: ambari > > > Description > ------- > > Ambari rack awareness for Kafka. > https://issues.apache.org/jira/browse/AMBARI-21234 > > As an operations person it would be nice to manage Kafka rack awareness via > Ambari. Ambari allows node rack information to be configured and this > information can then be pulled in the Kafka stack and populated in the > server.properties file for Kafka. > Design: > This stack change uses the /clusterHostInfo/all_hosts and > /clusterHostInfo/all_racks paths and materializes them to a variable. Then it > uses linear search to find this node in the list of all hosts and it's > corresponding rack id. This information is then stored in a variable called > rack and which is materialized during the configure method of the broker > scripts. > This stack change relies on the node rack information stored in Ambari > therefore will enable both Ambari UI and Blueprints to be used for setting up > Kafka broker rack information. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.10.0/configuration/ranger-kafka-audit.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/KAFKA/0.10.0/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/common-services/KAFKA/0.10.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > 1327090aa7 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > c36a10ff28 > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/metainfo.xml > 12f6c45396 > ambari-server/src/main/resources/stacks/HDP/2.6/services/KAFKA/metainfo.xml > fb281361a1 > > > Diff: https://reviews.apache.org/r/60249/diff/7/ > > > Testing > ------- > > Manually deployed Kafka cluster and verified the broker.rack property is > correctly populated. > > > File Attachments > ---------------- > > trunk patch > > https://reviews.apache.org/media/uploaded/files/2017/07/11/b3e15e0d-a677-49bb-a3c9-6287181d60c3__AMBARI-21234-trunk.diff > > > Thanks, > > Ambud Sharma > >
