> On July 7, 2017, 5:29 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py > > Lines 558 (patched) > > <https://reviews.apache.org/r/60709/diff/1/?file=1771278#file1771278line558> > > > > We should not default to one particular stack over another > > Jonathan Hurley wrote: > I totally agree. However, this was the original code that was there and > removing it could expose all sorts of weirdo cracks. Something that we can't > afford right now. Are you OK with us keeping this (since it's the way it was) > and opening a Jira to track it?
Sure, let's add a Jira for any miscellaneous items. > On July 7, 2017, 5:29 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java > > Lines 104 (patched) > > <https://reviews.apache.org/r/60709/diff/1/?file=1771281#file1771281line104> > > > > I believe this should be called on ambari server start instead of this > > particular Ambari Upgrade. > > Jonathan Hurley wrote: > This is a specific issue to Ambari 2.5.2 since it changes the value of > what was on Ambari 2.5.1 and earlier. These properties are read-only (as > defined in the clsuter-env.xml) and are not exposed anywhere for changing. > That's why I put it on the upgrade. That's why I isolated it to the upgrade. > Do you really feel strongly that we need to put it on a server start? > 99.999999% of the time, it won't be needed, right? Server start could address any fixes in the stack_features.json. But again, this can be miscellaneous improvements after we get the critical path working. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60709/#review179892 ----------------------------------------------------------- On July 7, 2017, 6:31 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60709/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 6:31 p.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush > Luniya, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-21430 > https://issues.apache.org/jira/browse/AMBARI-21430 > > > Repository: ambari > > > Description > ------- > > Currently, the stack tools: > > - {{cluster-env/stack_features}} > - {{cluster-env/stack_tools}} > - {{cluster-env/stack_root}} > > Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2 > sets of stack tools from co-existing. Although Ambari doesn't support more > than a single stack in 2.x, we do support upgrades from one stack vendor to > another. Therefore, we need this support to send the right tools on the > commands. > > This will involve the following work: > - Changing the existing stack tools/features/root to have a stack name as the > key in the JSON > - Altering the existing {{cluster-env}} tools on upgrade > - Ensuring that the stack tools/features for a repository's stack exist when > distributing that stack > - Changing any Python code which references the stack tools (stack_tools.py, > alerts, etc) > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > 2b3df5f2da > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 02ae62daf3 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 04928de595 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java > fc66f53e11 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java > 3681eda976 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > d556b603a8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 64e0b14cfe > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 0dacb568c2 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 13114dd772 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java > 0ab8180027 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py > 32df7d3819 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py > 98d1899776 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py > 0e9fe741d0 > ambari-server/src/main/resources/host_scripts/alert_disk_space.py > 4c5834f83b > ambari-server/src/main/resources/host_scripts/alert_version_select.py > f8755c911f > > ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml > 93c79481f0 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json > 4627e731c5 > > ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json > fdbbdf96bc > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > a79e904cdf > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 878645b62a > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json > d1aab4bba8 > > ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml > 7df00eea8e > > ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json > e9e0ed219c > > ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json > 535b9d9e0d > > > Diff: https://reviews.apache.org/r/60709/diff/2/ > > > Testing > ------- > > PENDING > > > Thanks, > > Jonathan Hurley > >
