-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/
-----------------------------------------------------------
(Updated July 7, 2017, 5:48 p.m.)
Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Jayush
Luniya, Nate Cole, and Sid Wagle.
Changes
-------
Updated the BP config processor to use the values from the stack since they are
read only. This prevents the need to change existing BPs. Updated tests to pass.
Bugs: AMBARI-21430
https://issues.apache.org/jira/browse/AMBARI-21430
Repository: ambari
Description
-------
Currently, the stack tools:
- {{cluster-env/stack_features}}
- {{cluster-env/stack_tools}}
- {{cluster-env/stack_root}}
Are bound to the {{cluster-env}} without any sort of scoping. This prevents 2
sets of stack tools from co-existing. Although Ambari doesn't support more than
a single stack in 2.x, we do support upgrades from one stack vendor to another.
Therefore, we need this support to send the right tools on the commands.
This will involve the following work:
- Changing the existing stack tools/features/root to have a stack name as the
key in the JSON
- Altering the existing {{cluster-env}} tools on upgrade
- Ensuring that the stack tools/features for a repository's stack exist when
distributing that stack
- Changing any Python code which references the stack tools (stack_tools.py,
alerts, etc)
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
2b3df5f2da
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
02ae62daf3
ambari-common/src/main/python/resource_management/libraries/script/script.py
04928de595
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
fc66f53e11
ambari-server/src/main/java/org/apache/ambari/server/controller/ActionExecutionContext.java
3681eda976
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
d556b603a8
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
061cdf7207
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
64e0b14cfe
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
0dacb568c2
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
13114dd772
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
106d7c85b3
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog252.java
0ab8180027
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
32df7d3819
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
98d1899776
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py
0e9fe741d0
ambari-server/src/main/resources/host_scripts/alert_disk_space.py 4c5834f83b
ambari-server/src/main/resources/host_scripts/alert_version_select.py
f8755c911f
ambari-server/src/main/resources/stacks/BigInsights/4.0/configuration/cluster-env.xml
93c79481f0
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
4627e731c5
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_tools.json
fdbbdf96bc
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
a79e904cdf
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
878645b62a
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_tools.json
d1aab4bba8
ambari-server/src/main/resources/stacks/PERF/1.0/configuration/cluster-env.xml
7df00eea8e
ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_features.json
e9e0ed219c
ambari-server/src/main/resources/stacks/PERF/1.0/properties/stack_tools.json
535b9d9e0d
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
1c2f33ecfe
ambari-server/src/test/python/common-services/configs/hawq_default.json
79864a9525
ambari-server/src/test/python/host_scripts/TestAlertDiskSpace.py 0d47061945
ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json
a1d930c5c1
ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json
f959b1fd5d
ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json
05cb78a42b
ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json
4e7d8573d2
ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json
abe84abe47
ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json
fa791c1f09
ambari-server/src/test/python/stacks/utils/RMFTestCase.py 7dd39900dc
Diff: https://reviews.apache.org/r/60709/diff/3/
Changes: https://reviews.apache.org/r/60709/diff/2-3/
Testing
-------
PENDING
Thanks,
Jonathan Hurley
