----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60744/#review180028 -----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/get_ambari_version.py Lines 29 (patched) <https://reviews.apache.org/r/60744/#comment255029> Use "with open" to avoid not closing the file during exception. - Andrew Onischuk On July 10, 2017, 1:04 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60744/ > ----------------------------------------------------------- > > (Updated July 10, 2017, 1:04 p.m.) > > > Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, > and Robert Nettleton. > > > Bugs: AMBARI-21435 > https://issues.apache.org/jira/browse/AMBARI-21435 > > > Repository: ambari > > > Description > ------- > > In the mpacks we may want to know the version of Ambari, for example the Log > Search handles it's configuration in different ways depending on it's version > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/get_ambari_version.py > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60744/diff/1/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >
