-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60744/#review180029
-----------------------------------------------------------




ambari-common/src/main/python/ambari_commons/get_ambari_version.py
Lines 28 (patched)
<https://reviews.apache.org/r/60744/#comment255033>

    Version file may be changed in `ambari.properties`:
    
    ```
    server.version.file=/var/lib/ambari-server/resources/version
    ```



ambari-common/src/main/python/ambari_commons/get_ambari_version.py
Lines 33 (patched)
<https://reviews.apache.org/r/60744/#comment255031>

    Please add "server" to the message



ambari-common/src/main/python/ambari_commons/get_ambari_version.py
Lines 41 (patched)
<https://reviews.apache.org/r/60744/#comment255030>

    Move inside the `if`



ambari-common/src/main/python/ambari_commons/get_ambari_version.py
Lines 51 (patched)
<https://reviews.apache.org/r/60744/#comment255032>

    Please add "agent" to the message


- Attila Doroszlai


On July 10, 2017, 3:48 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60744/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 3:48 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Andrew Onischuk, Oliver Szabo, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21435
>     https://issues.apache.org/jira/browse/AMBARI-21435
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the mpacks we may want to know the version of Ambari, for example the Log 
> Search handles it's configuration in different ways depending on it's version
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/get_ambari_version.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60744/diff/2/
> 
> 
> Testing
> -------
> 
> Tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to