----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60745/#review180037 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py Lines 406-445 (original), 400-417 (patched) <https://reviews.apache.org/r/60745/#comment255037> It turns out that when adding STOP commands back, we encountered failures all over the place. The problem is that the conf-select tool installed by HDP doesn't take a stack root - it hard codes /usr/hdp (just like the one for BI hard coded /usr/iop) When sending down any command, the status_params.py consult this function to get the hadoop directory. The logic is like this: - If there is not an upgrade in progress, then just return /usr/hdp/current/hadoop-client/conf - If there is an upgrade in progress, then use the hadoop conf directory which matches this component's version *The odd part here is that we were also doing a conf_select.select() which failed b/c the stack component was still using a BigInsight number in its patch during the STOP command* This seems to have been a relic from the ancient HDP 2.2 days where conf-select didn't exist yet and we had to cover the initial upgrade/downgrade situation between 2.2 and 2.3 when conf-select was introduced. I decided to simply get rid of calling conf-select.select() during the upgrade and I left the exist code which says to invoke it if /usr/hdp/current/hadoop-client/conf is not a link. Technically this can never happen anymore, but I'd rather not change too many tangential areas of the upgrade code. - Jonathan Hurley On July 10, 2017, 10:31 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60745/ > ----------------------------------------------------------- > > (Updated July 10, 2017, 10:31 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-21432 > https://issues.apache.org/jira/browse/AMBARI-21432 > > > Repository: ambari > > > Description > ------- > > With stack features allowed to co-exist for cross stack upgrade, once > AMBARI-21430 is completed we should be able to do Stop All services from the > upgrade pack. > > This will allow EU to look seamless and similar to any intra-stack upgrade > with pre-checks and stop enabled. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py > facf186f0e > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 46260058cf > > ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 46260058cf > > > Diff: https://reviews.apache.org/r/60745/diff/1/ > > > Testing > ------- > > Performed an EU with Core services from BI to HDP. > > > Thanks, > > Jonathan Hurley > >
