-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60745/#review180049
-----------------------------------------------------------


Fix it, then Ship it!




Some trivial issues


ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
Line 472 (original), 441 (patched)
<https://reviews.apache.org/r/60745/#comment255047>

    "targetted" -> "targeted"



ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
Line 47 (original), 45 (patched)
<https://reviews.apache.org/r/60745/#comment255048>

    trailing whitespace



ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
Lines 124 (patched)
<https://reviews.apache.org/r/60745/#comment255049>

    trailing whitespace


- Attila Doroszlai


On July 10, 2017, 4:31 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60745/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 4:31 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-21432
>     https://issues.apache.org/jira/browse/AMBARI-21432
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> With stack features allowed to co-exist for cross stack upgrade, once 
> AMBARI-21430 is completed we should be able to do Stop All services from the 
> upgrade pack.
> 
> This will allow EU to look seamless and similar to any intra-stack upgrade 
> with pre-checks and stop enabled.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  facf186f0e 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  46260058cf 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
>  46260058cf 
> 
> 
> Diff: https://reviews.apache.org/r/60745/diff/1/
> 
> 
> Testing
> -------
> 
> Performed an EU with Core services from BI to HDP.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to