----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60802/#review180327 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java Lines 2100 (patched) <https://reviews.apache.org/r/60802/#comment255438> Can you use getStackId() here instead of toString()? Easier to track usages of... - Jonathan Hurley On July 12, 2017, 10:02 a.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60802/ > ----------------------------------------------------------- > > (Updated July 12, 2017, 10:02 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-21449 > https://issues.apache.org/jira/browse/AMBARI-21449 > > > Repository: ambari > > > Description > ------- > > `PreUpgradeCheckResourceProvider` expects `target_stack` property. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 113002606c > > > Diff: https://reviews.apache.org/r/60802/diff/1/ > > > Testing > ------- > > Manually tested that upgrade with pre-req checks can be started. > > > Thanks, > > Attila Doroszlai > >
