> On July 12, 2017, 8 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > > Lines 2100 (patched) > > <https://reviews.apache.org/r/60802/diff/1/?file=1774760#file1774760line2100> > > > > Can you use getStackId() here instead of toString()? Easier to track > > usages of...
Good point. - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60802/#review180327 ----------------------------------------------------------- On July 12, 2017, 8:20 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60802/ > ----------------------------------------------------------- > > (Updated July 12, 2017, 8:20 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-21449 > https://issues.apache.org/jira/browse/AMBARI-21449 > > > Repository: ambari > > > Description > ------- > > `PreUpgradeCheckResourceProvider` expects `target_stack` property. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 113002606ca47af3e9bc3f99b1a5044fce0f82d8 > > > Diff: https://reviews.apache.org/r/60802/diff/2/ > > > Testing > ------- > > Manually tested that upgrade with pre-req checks can be started. > > > Thanks, > > Attila Doroszlai > >
