----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/#review181111 -----------------------------------------------------------
Fix it, then Ship it! Ship It! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java Lines 81 (patched) <https://reviews.apache.org/r/61024/#comment256534> Can this be placed to a common place and avoid defining it in two places? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java Lines 345 (patched) <https://reviews.apache.org/r/61024/#comment256535> Add some comment what this method does. - Sebastian Toader On July 21, 2017, 2:21 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61024/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 2:21 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and > Sebastian Toader. > > > Bugs: AMBARI-21545 > https://issues.apache.org/jira/browse/AMBARI-21545 > > > Repository: ambari > > > Description > ------- > > Ldap configuration can be included in recommendation requests and validation > requests. Configuration is passed down to stack advisor in services.json > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java > d6714f9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java > 0632361 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java > 7ba1b18 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 356754d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java > 2eed23d > ambari-server/src/main/resources/properties.json 11ca7f6 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java > 6df8b8b > > > Diff: https://reviews.apache.org/r/61024/diff/1/ > > > Testing > ------- > > - Tested the rest interface manually > - Wrote new unit tests > - Ambari-server unit tests: PENDING > > > Thanks, > > Balázs Bence Sári > >
