-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61024/#review182388
-----------------------------------------------------------


Ship it!




Ship It!

- Laszlo Puskas


On Aug. 8, 2017, 1:40 p.m., Balázs Bence Sári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61024/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2017, 1:40 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Robert Levas, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-21545
>     https://issues.apache.org/jira/browse/AMBARI-21545
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ldap configuration can be included in recommendation requests and validation 
> requests. Configuration is passed down to stack advisor in services.json
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
>  d6714f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
>  0632361 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
>  7ba1b18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  356754d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
>  eaa4716 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
>  6df8b8b 
> 
> 
> Diff: https://reviews.apache.org/r/61024/diff/2/
> 
> 
> Testing
> -------
> 
> - Tested the rest interface manually
> - Wrote new unit tests
> - Ambari-server unit tests: PENDING
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Reply via email to