> On Июль 24, 2017, 4:55 п.п., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > > Lines 455 (patched) > > <https://reviews.apache.org/r/61074/diff/1/?file=1781333#file1781333line455> > > > > This looks like a hack to me. Can we have the validation check for > > existence of the resource filter in the params? Can that be done with > > minimal extra code?
That's a hack, as for me it's to late for refactor for 2.5.2. It's not enough to check if resource filter exists in the request, we also should check the it doesn't return emptry set of resources. If it's empty, we're getting the error in description. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61074/#review181227 ----------------------------------------------------------- On Июль 24, 2017, 7:32 д.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61074/ > ----------------------------------------------------------- > > (Updated Июль 24, 2017, 7:32 д.п.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-21551 > https://issues.apache.org/jira/browse/AMBARI-21551 > > > Repository: ambari > > > Description > ------- > > While performing RBAC API tests, found the following: > POST call: > {code} > http://<hostname>:8080/api/v1/clusters/cl1/requests > {"RequestInfo":{"command":"RESTART","context":"Restart all required > services","operation_level":"host_component"},"Requests/resource_filters":[{"hosts_predicate":"HostRoles/stale_configs=true"}]} > {code} > Returns: > {code} > { > "status" : 500, > message" : "An internal system exception occurred: Command execution cannot > proceed without a resource filter." > } > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 0b140e4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > a8f7638 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > d243e73 > > > Diff: https://reviews.apache.org/r/61074/diff/1/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
