> On Июль 24, 2017, 5:35 п.п., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > > Lines 1086 (patched) > > <https://reviews.apache.org/r/61074/diff/1/?file=1781332#file1781332line1086> > > > > Shouldn't it `return`, too? Otherwise what prevents the exception a > > few lines later?
You're right. Thank you. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61074/#review181231 ----------------------------------------------------------- On Июль 25, 2017, 8:59 д.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61074/ > ----------------------------------------------------------- > > (Updated Июль 25, 2017, 8:59 д.п.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-21551 > https://issues.apache.org/jira/browse/AMBARI-21551 > > > Repository: ambari > > > Description > ------- > > While performing RBAC API tests, found the following: > POST call: > {code} > http://<hostname>:8080/api/v1/clusters/cl1/requests > {"RequestInfo":{"command":"RESTART","context":"Restart all required > services","operation_level":"host_component"},"Requests/resource_filters":[{"hosts_predicate":"HostRoles/stale_configs=true"}]} > {code} > Returns: > {code} > { > "status" : 500, > message" : "An internal system exception occurred: Command execution cannot > proceed without a resource filter." > } > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > f4b650e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > a8f7638 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > d243e73 > > > Diff: https://reviews.apache.org/r/61074/diff/2/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
