> On July 27, 2017, 7:43 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > > Lines 268 (patched) > > <https://reviews.apache.org/r/61178/diff/1/?file=1784488#file1784488line268> > > > > Is this deleting the config with the original value from the > > BigInsights stack? > > Would EU to HDP 2.6 create it with a new config value? > > Attila Doroszlai wrote: > The value is already changed by the previous "update stack references" > step, hence `hdp` in it. > `spark.yarn.archive` is not added during EU nor used by HDP.
Since not used, then delete the config without checking the value - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61178/#review181604 ----------------------------------------------------------- On July 27, 2017, 2:28 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61178/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 2:28 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Eric Yang, Jonathan Hurley, > Sumit Mohanty, Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-21572 > https://issues.apache.org/jira/browse/AMBARI-21572 > > > Repository: ambari > > > Description > ------- > > Remove unnecessary `spark.yarn.archive` property (if value matches IOP > default one, except it's already converted to `hdfs:///hdp/...`). > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > f71e91adcb1091074f83f1f09759968de50c82a9 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 9d3cc1e48e090f8a1f43cfaeb024dbeabdf4384b > > > Diff: https://reviews.apache.org/r/61178/diff/1/ > > > Testing > ------- > > Tested upgrade from BI 4.2.5 to HDP 2.6 manually. Property is removed during > upgrade and no longer present in Spark configs. > > > Thanks, > > Attila Doroszlai > >
