> On July 28, 2017, 8:17 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > > Lines 266-269 (patched) > > <https://reviews.apache.org/r/61178/diff/2/?file=1785094#file1785094line266> > > > > This just deletes the property outright. The description of the bug > > says that if it's been converted to leave it. Is that actually the desired > > behavior?
"If this property isn't used by HDP it should be deleted during the stack upgrade." -- this is what's implemented. Also see comment above by Alejandro: "Since not used, then delete the config without checking the value". - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61178/#review181696 ----------------------------------------------------------- On July 28, 2017, 9:22 a.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61178/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 9:22 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Eric Yang, Jonathan Hurley, > Sumit Mohanty, Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-21572 > https://issues.apache.org/jira/browse/AMBARI-21572 > > > Repository: ambari > > > Description > ------- > > Remove unnecessary `spark.yarn.archive` property (if value matches IOP > default one, except it's already converted to `hdfs:///hdp/...`). > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > f71e91adcb1091074f83f1f09759968de50c82a9 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > 9d3cc1e48e090f8a1f43cfaeb024dbeabdf4384b > > > Diff: https://reviews.apache.org/r/61178/diff/2/ > > > Testing > ------- > > Tested upgrade from BI 4.2.5 to HDP 2.6 manually. Property is removed during > upgrade and no longer present in Spark configs. > > > Thanks, > > Attila Doroszlai > >
