----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review181975 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Aug. 1, 2017, 8:32 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61317/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2017, 8:32 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro > Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-21626 > https://issues.apache.org/jira/browse/AMBARI-21626 > > > Repository: ambari > > > Description > ------- > > During an upgrade from HDP 2.5 to HDP 2.6, the new configurations are not > created in HDP 2.6 - they're created in HDP 2.5 which causes services to fail > on restart. > > STR: > - Create an HDP 2.5 cluster with ZK + HDFS > - Do an EU to HDP 2.6 > > The EU will fail right after the "move stack version" step. > > It looks like the bug is in {{ConfigHelper}} where it ignores the passed-in > {{StackId}} and uses the Cluster's stack. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java > ff0becc822 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > b4f7120836 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 16fc971e27 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > a5b40ff256 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 06b6217051 > > > Diff: https://reviews.apache.org/r/61317/diff/2/ > > > Testing > ------- > > Full upgrade/downgrade > > UTs PENDING... > > > Thanks, > > Jonathan Hurley > >
