----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review182035 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Aug. 2, 2017, 12:32 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61317/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 12:32 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro > Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-21626 > https://issues.apache.org/jira/browse/AMBARI-21626 > > > Repository: ambari > > > Description > ------- > > During an upgrade from HDP 2.5 to HDP 2.6, the new configurations are not > created in HDP 2.6 - they're created in HDP 2.5 which causes services to fail > on restart. > > STR: > - Create an HDP 2.5 cluster with ZK + HDFS > - Do an EU to HDP 2.6 > > The EU will fail right after the "move stack version" step. > > It looks like the bug is in {{ConfigHelper}} where it ignores the passed-in > {{StackId}} and uses the Cluster's stack. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java > ff0becc822 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > b4f7120836 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 4b2e0f1ace > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > a5b40ff256 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 06b6217051 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java > 5ac7752ddf > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 9b85242ac8 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 3a29298161 > > ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_checks.xml > 4d4d972685 > > > Diff: https://reviews.apache.org/r/61317/diff/3/ > > > Testing > ------- > > Full upgrade/downgrade > > Tests run: 4803, Failures: 0, Errors: 0, Skipped: 36 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:33 min > [INFO] Finished at: 2017-08-02T09:18:35-04:00 > [INFO] Final Memory: 71M/959M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
