----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61660/#review183053 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java Lines 1522 (patched) <https://reviews.apache.org/r/61660/#comment259046> Lowercase ConditionColumnNames -> conditionColumnNames ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java Lines 317 (patched) <https://reviews.apache.org/r/61660/#comment259048> Doc. ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java Lines 320-322 (patched) <https://reviews.apache.org/r/61660/#comment259047> Let's make this message a bit better. Something like: if (currentVersionList.isEmpty()) { throw new AmbariException("Unable to find any CURRENT repositories."); } else if (currentVersionList.size() != 1) { throw new AmbariException("The following repositories were found to be CURRENT: ", StringUtils.join(currentVersionList, ",")); } - Jonathan Hurley On Aug. 15, 2017, 10:39 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61660/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2017, 10:39 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-21728 > https://issues.apache.org/jira/browse/AMBARI-21728 > > > Repository: ambari > > > Description > ------- > > Things missing: > - Address Jonathan's comment at https://reviews.apache.org/r/61503/ > - Oracle DB support > - (pending)Test coverage for AMBARI-21169 > - (pending)Prepare patch for trunk (forward-port an upgrade catalog) > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java > 01bec59e86 > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > bed21e8e04 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > d14021bc21 > > > Diff: https://reviews.apache.org/r/61660/diff/1/ > > > Testing > ------- > > preview of changes for now > > > Thanks, > > Dmitro Lisnichenko > >
