-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61660/
-----------------------------------------------------------

(Updated Aug. 17, 2017, 1:10 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

Add test coverage, address review comments


Summary (updated)
-----------------

Service and Patch Upgrade Catalog Changes for 2.6 - additional fixes


Bugs: AMBARI-21728
    https://issues.apache.org/jira/browse/AMBARI-21728


Repository: ambari


Description (updated)
-------

Things that were missing:
- Address Jonathan's comment at https://reviews.apache.org/r/61503/
- Oracle DB support
- Test coverage for AMBARI-21169

Also, will publish patch for trunk (forward-port an upgrade catalog) in a 
separate review request


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java 
01bec59e86 
  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
bed21e8e04 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/DbmsHelper.java
 603c33b919 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java
 34358a9283 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/H2Helper.java
 602117acf8 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/MySqlHelper.java
 2df4547b97 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/OracleHelper.java
 fa8ba027db 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/PostgresHelper.java
 b0aac455e4 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 d14021bc21 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
 d576cc8ef4 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61660/diff/2/

Changes: https://reviews.apache.org/r/61660/diff/1-2/


Testing (updated)
-------

mvn clean test


Thanks,

Dmitro Lisnichenko

Reply via email to