-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61699/
-----------------------------------------------------------
(Updated Aug. 16, 2017, 10:02 p.m.)
Review request for Ambari, Nate Cole and Robert Levas.
Changes
-------
This is kinda nuts. So I decided to also upgrade surefire to 2.20 (from 2.19)
in order to expose which test might have been crashing the builds. After I did
this, a couple of tests starting failing, most notably DDLTest.
Apparently we had a test case which compared the DDLs of other DBs to that of
Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns out,
we had inconsistencies!
Bugs: AMBARI-21735
https://issues.apache.org/jira/browse/AMBARI-21735
Repository: ambari
Description
-------
Regardless of what options are set via {{MAVEN_OPTS}} or even
{{-DargLine=...}}, the surefire plugin seems to force the hard coded arg lines
for forked VMs:
{code}
/Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java
-Xms512m -Xmx1024m -jar
{code}
Setting argLines to different values is never picked up.
Diffs (updated)
-----
ambari-project/pom.xml 91ddb45d09
ambari-server/pom.xml 3ff8218a70
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 806a6aeb57
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5
ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java
779c937cca
ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java
05a75b3e6a
pom.xml e7d75e46c2
Diff: https://reviews.apache.org/r/61699/diff/2/
Changes: https://reviews.apache.org/r/61699/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
