----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61699/#review183130 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Aug. 17, 2017, 8:28 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61699/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2017, 8:28 a.m.) > > > Review request for Ambari, Attila Doroszlai, Nate Cole, and Robert Levas. > > > Bugs: AMBARI-21735 > https://issues.apache.org/jira/browse/AMBARI-21735 > > > Repository: ambari > > > Description > ------- > > Regardless of what options are set via {{MAVEN_OPTS}} or even > {{-DargLine=...}}, the surefire plugin seems to force the hard coded arg > lines for forked VMs: > > {code} > /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre/bin/java > -Xms512m -Xmx1024m -jar > {code} > > Setting argLines to different values is never picked up. > > ***So I decided to also upgrade surefire to 2.20 (from 2.19) in order to > expose which test might have been crashing the builds. After I did this, a > couple of tests starting failing, most notably DDLTest.*** > > **Apparently we had a test case which compared the DDLs of other DBs to that > of Postgres. Surefire 2.19 wasn't running it, but 2.20 was. And, as it turns > out, we had inconsistencies!*** > > > Diffs > ----- > > ambari-project/pom.xml 91ddb45d09 > ambari-server/pom.xml 3ff8218a70 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql e27430abe9 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c73db6e8ac > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 52f680d89b > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 037e54082f > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > 806a6aeb57 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql cabc32afd5 > ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java > 779c937cca > > ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java > 05a75b3e6a > pom.xml e7d75e46c2 > > > Diff: https://reviews.apache.org/r/61699/diff/2/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ........................................ SUCCESS [ 3.848 > s] > [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.034 > s] > [INFO] Ambari Web ......................................... SUCCESS [01:51 > min] > [INFO] Ambari Views ....................................... SUCCESS [ 2.612 > s] > [INFO] Ambari Admin View .................................. SUCCESS [ 11.764 > s] > [INFO] ambari-utility ..................................... SUCCESS [ 4.849 > s] > [INFO] ambari-metrics ..................................... SUCCESS [ 0.348 > s] > [INFO] Ambari Metrics Common .............................. SUCCESS [ 5.817 > s] > [INFO] Ambari Metrics Hadoop Sink ......................... SUCCESS [ 16.685 > s] > [INFO] Ambari Metrics Flume Sink .......................... SUCCESS [ 4.450 > s] > [INFO] Ambari Metrics Kafka Sink .......................... SUCCESS [ 3.666 > s] > [INFO] Ambari Metrics Storm Sink .......................... SUCCESS [ 1.766 > s] > [INFO] Ambari Metrics Storm Sink (Legacy) ................. SUCCESS [ 1.498 > s] > [INFO] Ambari Metrics Collector ........................... SUCCESS [08:26 > min] > [INFO] Ambari Metrics Monitor ............................. SUCCESS [ 6.452 > s] > [INFO] Ambari Metrics Grafana ............................. SUCCESS [ 3.974 > s] > [INFO] Ambari Metrics Host Aggregator ..................... SUCCESS [ 5.351 > s] > [INFO] Ambari Metrics Assembly ............................ SUCCESS [ 26.000 > s] > [INFO] Ambari Service Advisor ............................. SUCCESS [ 0.780 > s] > [INFO] Ambari Server ...................................... SUCCESS [22:28 > min] > [INFO] Ambari Functional Tests ............................ SUCCESS [ 0.801 > s] > [INFO] Ambari Agent ....................................... SUCCESS [ 35.469 > s] > [INFO] Ambari Client ...................................... SUCCESS [ 0.024 > s] > [INFO] Ambari Python Client ............................... SUCCESS [ 0.351 > s] > [INFO] Ambari Groovy Client ............................... SUCCESS [ 5.979 > s] > [INFO] Ambari Shell ....................................... SUCCESS [ 0.025 > s] > [INFO] Ambari Python Shell ................................ SUCCESS [ 0.027 > s] > [INFO] Ambari Groovy Shell ................................ SUCCESS [ 3.565 > s] > [INFO] ambari-logsearch ................................... SUCCESS [ 0.065 > s] > [INFO] Ambari Logsearch Appender .......................... SUCCESS [ 0.166 > s] > [INFO] Ambari Logsearch Config Api ........................ SUCCESS [ 0.796 > s] > [INFO] Ambari Logsearch Config Zookeeper .................. SUCCESS [ 5.493 > s] > [INFO] Ambari Logsearch Log Feeder ........................ SUCCESS [ 18.869 > s] > [INFO] Ambari Logsearch Web ............................... SUCCESS [ 37.389 > s] > [INFO] Ambari Logsearch Server ............................ SUCCESS [01:36 > min] > [INFO] Ambari Logsearch Assembly .......................... SUCCESS [ 0.083 > s] > [INFO] Ambari Logsearch Integration Test .................. SUCCESS [ 11.470 > s] > [INFO] ambari-infra ....................................... SUCCESS [ 0.016 > s] > [INFO] Ambari Infra Solr Client ........................... SUCCESS [ 2.706 > s] > [INFO] Ambari Infra Solr Plugin ........................... SUCCESS [ 27.113 > s] > [INFO] Ambari Infra Manager ............................... SUCCESS [ 9.795 > s] > [INFO] Ambari Infra Solr Assembly ......................... SUCCESS [ 0.052 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 39:02 min > [INFO] Finished at: 2017-08-16T23:07:49-04:00 > [INFO] Final Memory: 204M/960M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
