----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61744/#review183239 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java Lines 308 (patched) <https://reviews.apache.org/r/61744/#comment259261> YANR --> YARN ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java Lines 314 (patched) <https://reviews.apache.org/r/61744/#comment259264> Extra line ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java Lines 96-97 (patched) <https://reviews.apache.org/r/61744/#comment259265> These should be directives rather than resource properties. See `org.apache.ambari.server.api.resources.ClusterResourceDefinition#getUpdateDirectives`. - Robert Levas On Aug. 18, 2017, 1:12 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61744/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 1:12 p.m.) > > > Review request for Ambari, Robert Levas and Sebastian Toader. > > > Bugs: AMBARI-21757 > https://issues.apache.org/jira/browse/AMBARI-21757 > > > Repository: ambari > > > Description > ------- > > regenerateKeytab request now can accept host list and components list to > regenerate keytabs for. > > Example: > 'http://lc6401.ambari.apache.org:8080/api/v1/clusters/cl1?regenerate_keytabs=all&Kerberos/hosts=lc6401.ambari.apache.org&Kerberos/components=HDFS:NAMENODE;DATANODE,YARN:RESOURCEMANAGER' > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > 6c6c439 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > abb017b > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > b220999 > > > Diff: https://reviews.apache.org/r/61744/diff/1/ > > > Testing > ------- > > mvn clean test. manual tests on deployed cluster. > > > Thanks, > > Eugene Chekanskiy > >
