> On Aug. 22, 2017, 9:47 a.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > > Lines 314-327 (patched) > > <https://reviews.apache.org/r/61744/diff/2/?file=1800964#file1800964line314> > > > > Since trunk is already java8 worth checking if this method can be > > implemented in a simpler way using lambdas.
There is a chance that we need this to be backported to 2.5.0 > On Aug. 22, 2017, 9:47 a.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > > Lines 323 (patched) > > <https://reviews.apache.org/r/61744/diff/2/?file=1800964#file1800964line323> > > > > Why not adding ```Set.emptySet()``` instead of ```null```? That would > > save using null checks laster in the code. later logic checks for filter existance OR item existance in filter, so null looks good here(I mean no reason what to check, lenght of filter or if filter is null, just will add some docs for this to make this clear) - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61744/#review183453 ----------------------------------------------------------- On Aug. 21, 2017, 4:31 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61744/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 4:31 p.m.) > > > Review request for Ambari, Robert Levas and Sebastian Toader. > > > Bugs: AMBARI-21757 > https://issues.apache.org/jira/browse/AMBARI-21757 > > > Repository: ambari > > > Description > ------- > > regenerateKeytab request now can accept host list and components list to > regenerate keytabs for. > > Example: > 'http://lc6401.ambari.apache.org:8080/api/v1/clusters/cl1?regenerate_keytabs=all&Kerberos/hosts=lc6401.ambari.apache.org&Kerberos/components=HDFS:NAMENODE;DATANODE,YARN:RESOURCEMANAGER' > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java > f689841 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > 3819863 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > 6c6c439 > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > b220999 > > > Diff: https://reviews.apache.org/r/61744/diff/2/ > > > Testing > ------- > > mvn clean test. manual tests on deployed cluster. > > > Thanks, > > Eugene Chekanskiy > >
