----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review184878 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py Line 22 (original), 22 (patched) <https://reviews.apache.org/r/61994/#comment261080> _UBUNTU_REPO_COMPONENTS_POSTFIX is hardcoded to "main" but it is possible that some debian repo for a custom service uses a different component name For example: deb http://url mydistro mycomponent We should see if we can parameterize component names as well (default being "main" if it is not defined). ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py Line 48 (original), 48 (patched) <https://reviews.apache.org/r/61994/#comment261078> If repo['distribution'] is not defined then we should use repo['repoName'] as the distrbution. This will maintain compatibility for HDP deployments ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml Lines 95 (patched) <https://reviews.apache.org/r/61994/#comment261076> We dont need to change it for HDP. For HDP the distribution should remain HDP. i.e. deb http://public-repo-1/.... HDP main KIBANA service in Metron mpack requires setting distribution=stable. "distribution" should be an optional parameter. - Jayush Luniya On Sept. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61994/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 8:40 p.m.) > > > Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-21856 > https://issues.apache.org/jira/browse/AMBARI-21856 > > > Repository: ambari > > > Description > ------- > > The problem is that Ambari is using the reponame name field as the > distribution when it creates the repo definition file. Since both of these > repos use same distribution (which is a common Debian pattern), they collide. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > 3d96122 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 1a022af > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 0735e27 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java > bad8195 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java > 854f03f > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java > 5e1d5d3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java > 17ded10 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 058c45b > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml ff132aa > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > 3a7b19b > > > Diff: https://reviews.apache.org/r/61994/diff/2/ > > > Testing > ------- > > test will be fixed after solution will be approved > > > Thanks, > > Vitalyi Brodetskyi > >
