----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review185437 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py Lines 126 (patched) <https://reviews.apache.org/r/61994/#comment261744> Can we make this as components instead of single component. We can consider components to be a comma separated list. Some debian repos also have multiple components although I don't think its commonly used. But just incase someone has a special case we don't have to revisit this. https://wiki.debian.org/SourcesList deb http://deb.debian.org/debian stretch main contrib non-free deb-src http://deb.debian.org/debian stretch main contrib non-free deb http://deb.debian.org/debian stretch-updates main contrib non-free deb-src http://deb.debian.org/debian stretch-updates main contrib non-free deb http://security.debian.org/ stretch/updates main contrib non-free deb-src http://security.debian.org/ stretch/updates main contrib non-free - Jayush Luniya On Sept. 13, 2017, 5:37 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61994/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 5:37 p.m.) > > > Review request for Ambari, Jayush Luniya, Nate Cole, and Sid Wagle. > > > Bugs: AMBARI-21856 > https://issues.apache.org/jira/browse/AMBARI-21856 > > > Repository: ambari > > > Description > ------- > > The problem is that Ambari is using the reponame name field as the > distribution when it creates the repo definition file. Since both of these > repos use same distribution (which is a common Debian pattern), they collide. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/repository_util.py > 32b8038 > > ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java > 858a55f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > c78d88d > > ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java > 0735e27 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > 88ece8f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java > bad8195 > ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java > d43bdfa > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java > 854f03f > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java > 5e1d5d3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java > 17ded10 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java > 8427a1d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py > 058c45b > ambari-server/src/main/resources/version_definition.xsd 832d7f9 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RepositoryVersionEventCreatorTest.java > 18e2d3f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java > 3a7b19b > > > Diff: https://reviews.apache.org/r/61994/diff/3/ > > > Testing > ------- > > test will be fixed after solution will be approved > > > Thanks, > > Vitalyi Brodetskyi > >
