> On Sept. 12, 2017, 5:14 p.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java > > Line 151 (original), 159 (patched) > > <https://reviews.apache.org/r/62258/diff/1/?file=1820300#file1820300line172> > > > > can we move amount of threads to constant, to make it more easy to tune > > in the future?
Will do. > On Sept. 12, 2017, 5:14 p.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java > > Lines 219 (patched) > > <https://reviews.apache.org/r/62258/diff/1/?file=1820300#file1820300line233> > > > > Looks like not used assign Thanks for reviewing. Will fix this - it was part of debugging. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62258/#review185235 ----------------------------------------------------------- On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62258/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 4:10 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan > Hurley. > > > Bugs: AMBARI-21941 > https://issues.apache.org/jira/browse/AMBARI-21941 > > > Repository: ambari > > > Description > ------- > > Starting Ambari will load all the hdp_urlinfo.json and files and VDF in a > sequential manner. This is all in a single-threaded Executor. When that > happens, the data can take upwards of a full minute to be populated in some > cases. This should be multi-threaded. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java > da7f021059 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > cbbe92e8cc > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > f1412f543e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java > c43ce7c628 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62258/diff/1/ > > > Testing > ------- > > This is a refactor only. Existing tests cover the functionality needed while > just adding a performance boost to loading VDF. > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
