> On Sept. 13, 2017, 9:21 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java > > Lines 204 (patched) > > <https://reviews.apache.org/r/62258/diff/1/?file=1820300#file1820300line218> > > > > Should we log a warning here (not exception, but just message?
Thanks for reviewing. Will do. > On Sept. 13, 2017, 9:21 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java > > Lines 156 (patched) > > <https://reviews.apache.org/r/62258/diff/1/?file=1820305#file1820305line156> > > > > How many of these calls are there usually? If only like 10, then maybe > > log to INFO since it only happens on startup? If 100, I guess debug is > > right. Yeah, I thought of that - the issue I have is that it will give you an idea of an individual VDF, but not how long it takes as a whole. And since versions are loaded in their own threads, you'll see mixed VDF messages interspersed with one another. The most I've seen is around 120 - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62258/#review185284 ----------------------------------------------------------- On Sept. 12, 2017, 4:10 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62258/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2017, 4:10 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Jonathan > Hurley. > > > Bugs: AMBARI-21941 > https://issues.apache.org/jira/browse/AMBARI-21941 > > > Repository: ambari > > > Description > ------- > > Starting Ambari will load all the hdp_urlinfo.json and files and VDF in a > sequential manner. This is all in a single-threaded Executor. When that > happens, the data can take upwards of a full minute to be populated in some > cases. This should be multi-threaded. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java > da7f021059 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > cbbe92e8cc > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > f1412f543e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java > c43ce7c628 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoUrlInfoCallable.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoVdfCallable.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62258/diff/1/ > > > Testing > ------- > > This is a refactor only. Existing tests cover the functionality needed while > just adding a performance boost to loading VDF. > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >