-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-22007
https://issues.apache.org/jira/browse/AMBARI-22007
Repository: ambari
Description
-------
This bug will affect adding components to hosts where other versions of the
component was already installed. It occurs because Storm was already installed
on the machine you added the Supervisor to and the symlinks were already
created with the older version.
Example:
{code:title=After Patch, Before Adding Supervisor}
/usr/hdp/current/storm-client -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-nimbus -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-supervisor -> /usr/hdp/2.6.0.0-102/storm
{code}
The installation of any Storm component causes the symlink for
{{storm-supervisor}} to also get created. However, when the upgrade was
applied, it didn't upgrade supervisor on this machine since it technically
wasn't installed there (at least as far as Ambari is concerned).
Any other test which follows this pattern will fail until I can fix this.
However, adding a branch new host should work correctly and install the new
version.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
9fbb42bec5
ambari-common/src/main/python/resource_management/libraries/script/script.py
99184d1fbc
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
1b04d62408
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
d14b92f465
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
e1da8131ea
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
a377350fc0
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
aa298944fe
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
b812476d31
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
04dfe7a61e
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
c6a85d0c04
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
6b78dd6fd0
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql cea350c70b
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 6bb903fef7
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 543aee167a
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 276cd2a184
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql ea2c927b31
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 90014b61aa
Diff: https://reviews.apache.org/r/62448/diff/1/
Testing
-------
PENDING...
Thanks,
Jonathan Hurley