-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/
-----------------------------------------------------------
(Updated Sept. 20, 2017, 3:59 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-22007
https://issues.apache.org/jira/browse/AMBARI-22007
Repository: ambari
Description
-------
This bug will affect adding components to hosts where other versions of the
component was already installed. It occurs because Storm was already installed
on the machine you added the Supervisor to and the symlinks were already
created with the older version.
Example:
{code:title=After Patch, Before Adding Supervisor}
/usr/hdp/current/storm-client -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-nimbus -> /usr/hdp/2.6.0.3-8/storm
/usr/hdp/current/storm-supervisor -> /usr/hdp/2.6.0.0-102/storm
{code}
The installation of any Storm component causes the symlink for
{{storm-supervisor}} to also get created. However, when the upgrade was
applied, it didn't upgrade supervisor on this machine since it technically
wasn't installed there (at least as far as Ambari is concerned).
Any other test which follows this pattern will fail until I can fix this.
However, adding a branch new host should work correctly and install the new
version.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py
9fbb42bec5
ambari-common/src/main/python/resource_management/libraries/script/script.py
59401669f8
ambari-server/src/main/java/org/apache/ambari/server/agent/CommandRepository.java
135171391f
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
3c15d92948
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
e1da8131ea
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java
aa298944fe
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
b812476d31
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
72269f0f7c
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
3ab28e9a5c
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
afd3d1d6a5
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 796d9b2d7a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c0026013c0
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql d78c1c78c6
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 90f1397b94
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql c4bb76314b
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9f7aa912ec
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListenerTest.java
cd8b499e1e
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
ddff0e9560
ambari-server/src/test/python/TestVersionSelectUtil.py 38798e2b70
Diff: https://reviews.apache.org/r/62448/diff/3/
Changes: https://reviews.apache.org/r/62448/diff/2-3/
Testing (updated)
-------
mvn clean test
Patch Upgrade follow by adding components
New cluster deployment via UI using ambiguous repo
Thanks,
Jonathan Hurley
