> On Oct. 4, 2017, 12:54 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > > Lines 21 (patched) > > <https://reviews.apache.org/r/62756/diff/1/?file=1845302#file1845302line21> > > > > Can we also remove the duplicate code in HDP stack advisors? > > Vitalyi Brodetskyi wrote: > Which code i should remove? If you are talking about all AMS methods > (recommendations and validations), i don't think we can remove them. As of > now, only HDP 3.0 work with service advisors, all other stacks work with > stack advisor.
No support for service advisor was add a while back. We already have LOGSEARCH, AMBARI_INFRA, NIFI that define service advisors. See https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/service_advisor.py The default stack advisor has installation hooks to call individual service advisors https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/stack_advisor.py#L765 Can you try and see? - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review187037 ----------------------------------------------------------- On Oct. 4, 2017, 8:26 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62756/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 8:26 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Sid Wagle. > > > Bugs: AMBARI-22124 > https://issues.apache.org/jira/browse/AMBARI-22124 > > > Repository: ambari > > > Description > ------- > > We need to move AMS specific logic in the stack advisors to service advisor. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py > a2e31cc > > > Diff: https://reviews.apache.org/r/62756/diff/2/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
