----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review187229 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On Oct. 5, 2017, 2:22 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62756/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2017, 2:22 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Jayush Luniya, Madhuvanthi > Radhakrishnan, and Sid Wagle. > > > Bugs: AMBARI-22124 > https://issues.apache.org/jira/browse/AMBARI-22124 > > > Repository: ambari > > > Description > ------- > > We need to move AMS specific logic in the stack advisors to service advisor. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py > a2e31cc > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 5307176 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 2dc1738 > > ambari-server/src/test/python/common-services/AMBARI_METRICS/test_service_advisor.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 65b23b0 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > d6b572e > > > Diff: https://reviews.apache.org/r/62756/diff/4/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
