----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/#review187876 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java Line 87 (original), 86 (patched) <https://reviews.apache.org/r/62949/#comment264909> Thank you! I think this was my fault anyway from like 3 months ago :) ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java Lines 365-375 (original), 364-371 (patched) <https://reviews.apache.org/r/62949/#comment264911> Does this change work for revert? If you've finallized, then we've send the event which tells services to reload their components from the new desired stack IDs. On revert of that patch, at this point, they would still be the new stack IDs, right? I guess no componenents should be changing this between 3rd and 4th digits anyway. Just wanted to check - if you think this case isn't valid, then drop the issue. - Jonathan Hurley On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62949/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 4:46 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-22226 > https://issues.apache.org/jira/browse/AMBARI-22226 > > > Repository: ambari > > > Description > ------- > > The code to check versions was only looking at the upgrade context repo > version, not the target service repo > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java > f80d06accc > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 0ce5d30b0b > > > Diff: https://reviews.apache.org/r/62949/diff/1/ > > > Testing > ------- > > No new tests, just verify existing tests pass. > Manual. Unit pending. > > > Thanks, > > Nate Cole > >
