> On Oct. 12, 2017, 5:46 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > > Lines 365-375 (original), 364-371 (patched) > > <https://reviews.apache.org/r/62949/diff/1/?file=1853845#file1853845line365> > > > > Does this change work for revert? If you've finallized, then we've send > > the event which tells services to reload their components from the new > > desired stack IDs. > > > > On revert of that patch, at this point, they would still be the new > > stack IDs, right? > > > > I guess no componenents should be changing this between 3rd and 4th > > digits anyway. Just wanted to check - if you think this case isn't valid, > > then drop the issue. > > Nate Cole wrote: > I'll test that scenario.
Tested RU/Downgrade, RU/Finalize, EU/Downgrade, EU/Finalize and PU/Downgrade, PU/Finalize and they all worked as expected. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/#review187876 ----------------------------------------------------------- On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62949/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 4:46 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-22226 > https://issues.apache.org/jira/browse/AMBARI-22226 > > > Repository: ambari > > > Description > ------- > > The code to check versions was only looking at the upgrade context repo > version, not the target service repo > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java > f80d06accc > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 0ce5d30b0b > > > Diff: https://reviews.apache.org/r/62949/diff/1/ > > > Testing > ------- > > No new tests, just verify existing tests pass. > Manual. Unit tests: > > [INFO] > [INFO] Results: > [INFO] > [WARNING] Tests run: 4919, Failures: 0, Errors: 0, Skipped: 34 > [INFO] > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:49.685s > [INFO] Finished at: Thu Oct 12 17:00:33 EDT 2017 > [INFO] Final Memory: 108M/1943M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
