----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63840/#review191168 -----------------------------------------------------------
ambari-web/app/messages.js Lines 882 (patched) <https://reviews.apache.org/r/63840/#comment268777> Please choose more specific name than "body2" ambari-web/app/models/stack_service.js Lines 26 (patched) <https://reviews.apache.org/r/63840/#comment268778> get works with multiple keys: get('service.serviceName') ambari-web/app/models/stack_service.js Lines 44 (patched) <https://reviews.apache.org/r/63840/#comment268779> Why this is computed if it always return constant? Also string should be in translations. ambari-web/app/models/stack_service.js Lines 61 (patched) <https://reviews.apache.org/r/63840/#comment268790> should be computed property ambari-web/app/models/stack_service.js Lines 70 (patched) <https://reviews.apache.org/r/63840/#comment268791> should be computed property ambari-web/app/models/stack_service.js Lines 126 (patched) <https://reviews.apache.org/r/63840/#comment268795> From performance perspectives, this better be done in a single loop ambari-web/app/models/stack_service.js Lines 147 (patched) <https://reviews.apache.org/r/63840/#comment268792> You can use someProperty instead. - Andrii Tkach On Nov. 15, 2017, 4:46 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63840/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 4:46 p.m.) > > > Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole. > > > Bugs: AMBARI-22449 > https://issues.apache.org/jira/browse/AMBARI-22449 > > > Repository: ambari > > > Description > ------- > > Selecting a service that requires HDFS triggers the addServicePopup and HDFS > is automatically selected, even if an other HDFS compatible service like > OneFS is already selected. The UI should recognize OneFS as an alternative > option of HDFS. > > If the user selects a service that needs HDFS and other HDFS compatible > services are presented in the stack, then the UI should show that there are > multiple options to resolve the problem and instruct the user to choose one > compatible service. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step4_controller.js d82bf34 > ambari-web/app/messages.js 3c4f038 > ambari-web/app/models/stack_service.js 241f6ab > ambari-web/test/controllers/wizard/step4_test.js 0fad0c1 > > > Diff: https://reviews.apache.org/r/63840/diff/1/ > > > Testing > ------- > > 1. Tried to add HBASE without selecting HDFS or ONEFS > 2. UI showed popup saying I need to select either HDFS or ONEFS > 3. Selected ONEFS > 4. Pressed next, no popup > > 1. Tried to add HBAES when ONEFS was already selected > 2. Pressed next, no popup > > 1. checked existing cases when ONEFS mpack was not installed > > existing tests: passed > > > Thanks, > > Attila Magyar > >
