-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63840/
-----------------------------------------------------------

(Updated Nov. 16, 2017, 12:56 p.m.)


Review request for Ambari, Alexandr Antonenko, Andrii Tkach, and Nate Cole.


Changes
-------

addressed review comments


Bugs: AMBARI-22449
    https://issues.apache.org/jira/browse/AMBARI-22449


Repository: ambari


Description
-------

Selecting a service that requires HDFS triggers the addServicePopup and HDFS is 
automatically selected, even if an other HDFS compatible service like OneFS is 
already selected. The UI should recognize OneFS as an alternative option of 
HDFS.

If the user selects a service that needs HDFS and other HDFS compatible 
services are presented in the stack, then the UI should show that there are 
multiple options to resolve the problem and instruct the user to choose one 
compatible service.


Diffs (updated)
-----

  ambari-web/app/controllers/wizard/step4_controller.js d82bf34 
  ambari-web/app/messages.js 3c4f038 
  ambari-web/app/models/stack_service.js 241f6ab 
  ambari-web/test/controllers/wizard/step4_test.js 0fad0c1 


Diff: https://reviews.apache.org/r/63840/diff/2/

Changes: https://reviews.apache.org/r/63840/diff/1-2/


Testing
-------

1. Tried to add HBASE without selecting HDFS or ONEFS
2. UI showed popup saying I need to select either HDFS or ONEFS
3. Selected ONEFS
4. Pressed next, no popup

1. Tried to add HBAES when ONEFS was already selected
2. Pressed next, no popup

1. checked existing cases when ONEFS mpack was not installed

existing tests: passed


Thanks,

Attila Magyar

Reply via email to