> On Dec. 16, 2017, 10:35 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > > Lines 160-164 (patched) > > <https://reviews.apache.org/r/64667/diff/1/?file=1919066#file1919066line161> > > > > We should not hard code this into install_packages. Can we just expose > > this method for the Livy Python files to call?
In this case, this code should run before install_packages.py . Otherwise, symlinks will be badly broken, and my code will not be able to fix that. I can move the code to restart() of Livy, but we would have to require users (via release notes) to restart Livy before installing packages for a new stack. Should I move this code to restart? Or should leave it as is, intending to refactor/generalize it at 2.6.2? - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64667/#review194019 ----------------------------------------------------------- On Dec. 16, 2017, 5:53 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64667/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2017, 5:53 p.m.) > > > Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Nate Cole. > > > Bugs: AMBARI-22522 > https://issues.apache.org/jira/browse/AMBARI-22522 > > > Repository: ambari > > > Description > ------- > > Adding a small, livy-only workaround into install_packages.py > > > Diffs > ----- > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > c8497cd > > > Diff: https://reviews.apache.org/r/64667/diff/1/ > > > Testing > ------- > > mvn clean test, > live cluster check > > > Thanks, > > Dmitro Lisnichenko > >
