-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64667/#review194033
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/custom_actions/scripts/install_packages.py
Lines 155 (patched)
<https://reviews.apache.org/r/64667/#comment272724>

    OK - let's just make this a little less hard-coded ...
    
    Can we pass in the paramters of livy/livy-server to this method and call it 
something like "fix_default_links"
    
    We should also have some documentation as to why we need this method ...


- Jonathan Hurley


On Dec. 16, 2017, 10:53 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64667/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2017, 10:53 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Mahadev Konar, and Nate Cole.
> 
> 
> Bugs: AMBARI-22522
>     https://issues.apache.org/jira/browse/AMBARI-22522
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding a small, livy-only workaround into install_packages.py
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> c8497cd 
> 
> 
> Diff: https://reviews.apache.org/r/64667/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test,
> live cluster check
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to