> On June 3, 2014, 4:32 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/test_config.py, line 24 > > <https://reviews.apache.org/r/22207/diff/1/?file=602877#file602877line24> > > > > These import order fixing will need to be rebased if > > https://reviews.apache.org/r/22165 gets in first. > > Mark Chu-Carroll wrote: > Yeah, I know. But I installed the python checkstyle, and it caught > several things in this, so it's worth the merge cost. >
I have been dancing around this with: drop pre-commit hook + build-support/isort-run + revert RB:22165 files + commit + install pre-commit hook :) - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22207/#review44632 ----------------------------------------------------------- On June 3, 2014, 3:30 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22207/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 3:30 p.m.) > > > Review request for Aurora, David McLaughlin and Maxim Khutornenko. > > > Bugs: aurora-497 > https://issues.apache.org/jira/browse/aurora-497 > > > Repository: aurora > > > Description > ------- > > Prevent keyboard interrupts from spewing stack dumps. > > (Also, cleanup python isort failures.) > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > fd6f96ebe4acd358409f145178ebf8ad5ea27d05 > src/main/python/apache/aurora/client/cli/client.py > 1fb5364894d230646592942434eb1da6554d5c05 > src/main/python/apache/aurora/client/cli/config.py > 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122 > src/main/python/apache/aurora/client/cli/cron.py > c30a0a605412229f3e4cddbe8c5ae746f256e30c > src/test/python/apache/aurora/client/api/test_sla.py > 9c3bb6d386abbdbbfa8746639798ddca01d54fe9 > src/test/python/apache/aurora/client/cli/test_config_noun.py > 7a9d733835e204bfd179e698bc335435b837d24b > src/test/python/apache/aurora/client/cli/test_create.py > b186b52416a2fae8de28fd1d21e7eec07fea8e55 > src/test/python/apache/aurora/client/cli/test_cron.py > 049405a4323fc73102d6ac1dae2230be4325c530 > src/test/python/apache/aurora/client/test_config.py > 4b3e1499c7447792288f4b480cbd756c8e19a831 > src/test/sh/org/apache/aurora/e2e/http_example.py > 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66 > > Diff: https://reviews.apache.org/r/22207/diff/ > > > Testing > ------- > > Added a new test of interrupt, and ran all client tests. > > > Thanks, > > Mark Chu-Carroll > >
